diff options
| author | soryu <soryu@soryu.co> | 2026-05-01 23:56:51 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-05-01 23:56:51 +0100 |
| commit | e11759447b1ac00becfb1e979e488f7f9c9cf478 (patch) | |
| tree | f8a58368de3f6dda3f2f5c1af34e869a0e714205 /makima/frontend/src/components/contracts/PhaseHint.tsx | |
| parent | 80085c7cfa9d679ed3e3fd54a7d55fa8ab1addef (diff) | |
| download | soryu-e11759447b1ac00becfb1e979e488f7f9c9cf478.tar.gz soryu-e11759447b1ac00becfb1e979e488f7f9c9cf478.zip | |
chore(cleanup): Phase 5 contracts removal + tmp directive + 30-day expiry + scroll fix (#118)
Sweeping cleanup across the surface and the wire. Net: -14k LOC of legacy
contracts code, plus the tmp/scroll/UX fixes the user asked for.
## Sidebar/editor independent scroll
Replace `height: calc(100vh - 80px)` (which assumed an 80px masthead and
quietly clipped or pushed the whole page below the fold when the masthead
was taller) with `h-screen + overflow-hidden` on the page root and proper
`flex-1 min-h-0` sizing on `<main>`. Sidebar and editor pane now manage
their own scroll independently; the page itself never scrolls.
Same fix in /tmp/:taskId.
## tmp directive — real backing for orphans/ephemerals
New migration `20260501100000_tmp_directive_and_clear_orphans.sql`:
* Adds `directives.is_tmp` BOOLEAN NOT NULL DEFAULT false.
* Partial unique index `(owner_id) WHERE is_tmp` — at most ONE tmp
directive per owner.
* Hard-deletes every existing orphan task (`directive_id IS NULL`).
Per the user spec: "ALSO there are TOO MANY old tasks in tmp, we
need to remove all of them as well."
New repository helpers:
* `get_or_create_tmp_directive(pool, owner_id) -> Directive`
INSERT ON CONFLICT DO NOTHING + fallback SELECT, race-safe.
* `list_all_tmp_directives` — drives the expiry sweep.
* `delete_expired_tmp_tasks(tmp_directive_id) -> u64`.
* `list_tmp_tasks_for_owner` (replaces `list_orphan_tasks_for_owner`).
`mesh::create_task`: every top-level task must have a directive. If a
caller doesn't supply `directive_id` and isn't a subtask, attach to the
caller's tmp directive (auto-creating it on first use).
`list_directives_for_owner` filters out `is_tmp=true` so the scratchpad
directive doesn't pollute the contract list — surfaced via the sidebar's
`tmp/` folder instead.
## 30-day expiry on tmp tasks
New `phase_tmp_expiry` in the directive reconciler. Throttled to once per
hour: enumerates every tmp directive, calls `delete_expired_tmp_tasks`,
logs the count. The actual delete is `WHERE created_at < NOW() - INTERVAL
'30 days'` and is fast on the existing index. Subtasks die via FK cascade.
## Phase 5 — contracts removed
### Frontend
Deleted entire `/contracts` surface:
* routes: `contracts.tsx`, `contract-file.tsx`
* components/contracts: ContractList, ContractDetail, ContractCliInput,
ContractContextMenu, CommandModePanel, PhaseBadge, PhaseHint,
PhaseDeliverablesPanel, PhaseProgressBar, QuickActionButtons,
RepositoryPanel, TaskDerivationPreview
* (Kept `PhaseConfirmationModal` — used outside the contracts surface
by `TaskOutput` and `PhaseConfirmationNotification`.)
* Routes deregistered from `main.tsx`; nav entry removed from
`NavStrip`.
### Backend handlers
Deleted: `contracts.rs` (2.4k LOC), `contract_chat.rs` (3.2k LOC),
`contract_daemon.rs` (~940 LOC), `contract_discuss.rs` (~590 LOC),
`transcript_analysis.rs` (~690 LOC). All `/api/v1/contracts/*` routes
deregistered. OpenAPI entries dropped. Module declarations removed from
`server/handlers/mod.rs`.
### CLI
Removed `makima contract` and `makima supervisor` subcommands. Deleted
`daemon/cli/contract.rs` and `daemon/cli/supervisor.rs`. Bin dispatch
trimmed (~377 LOC).
### Orchestrator
Removed the contract-spawn path from `phase_execution`
(`spawn_step_contract` and its caller). `directive_steps.contract_type`
now logs a warning and falls through to standalone-task spawn. Column
itself stays — old data still reads, just no longer triggers a
contract+supervisor spawn.
### TUI
`Action::PerformCreateContract` is now a no-op that surfaces a status
message: "Contracts have been removed. Use directives instead." The TUI
form is dead code pending a wider refresh.
## Out of scope (deliberately left)
* Contracts DB tables (`contracts`, `contract_repositories`,
`contract_chat_history`, `contract_events`, `contract_templates`) are
retained for historical data + because some peripheral code still
joins to them in TaskSummary queries.
* `mesh_supervisor` handlers are retained — they aren't only used by
contracts (some mesh-level supervisor behaviour persists), and the
cross-cutting cleanup is bigger than this PR.
* `directive_steps.contract_type` column itself isn't dropped; just no
longer functional.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'makima/frontend/src/components/contracts/PhaseHint.tsx')
| -rw-r--r-- | makima/frontend/src/components/contracts/PhaseHint.tsx | 90 |
1 files changed, 0 insertions, 90 deletions
diff --git a/makima/frontend/src/components/contracts/PhaseHint.tsx b/makima/frontend/src/components/contracts/PhaseHint.tsx deleted file mode 100644 index 95573ed..0000000 --- a/makima/frontend/src/components/contracts/PhaseHint.tsx +++ /dev/null @@ -1,90 +0,0 @@ -import type { ContractPhase, ContractWithRelations } from "../../lib/api"; - -interface PhaseHintProps { - contract: ContractWithRelations; - onAdvancePhase: (phase: ContractPhase) => void; -} - -const phaseOrder: ContractPhase[] = ["research", "specify", "plan", "execute", "review"]; - -interface HintConfig { - condition: (contract: ContractWithRelations) => boolean; - message: (contract: ContractWithRelations) => string; - nextPhase: ContractPhase; -} - -const phaseHints: Record<ContractPhase, HintConfig | null> = { - research: { - condition: (c) => c.files.length >= 1, - message: (c) => - `You have ${c.files.length} file${c.files.length === 1 ? "" : "s"}. Ready to specify requirements?`, - nextPhase: "specify", - }, - specify: { - condition: (c) => c.files.length >= 2, - message: () => "Spec files ready. Create implementation plan?", - nextPhase: "plan", - }, - plan: { - condition: (c) => c.files.length >= 1 && c.repositories.length >= 1, - message: () => "Plan documented. Ready to create tasks?", - nextPhase: "execute", - }, - execute: { - condition: (c) => { - // Show hint only when all tasks are complete - const doneTasks = c.tasks.filter( - (t) => t.status === "done" || t.status === "merged" - ); - return c.tasks.length > 0 && doneTasks.length === c.tasks.length; - }, - message: (c) => { - const doneTasks = c.tasks.filter( - (t) => t.status === "done" || t.status === "merged" - ); - return `All ${doneTasks.length} task${doneTasks.length === 1 ? "" : "s"} complete. Ready for review?`; - }, - nextPhase: "review", - }, - review: null, // No hint for review phase - it's the final phase -}; - -export function PhaseHint({ contract, onAdvancePhase }: PhaseHintProps) { - const hintConfig = phaseHints[contract.phase]; - - // No hint for this phase - if (!hintConfig) return null; - - // Condition not met - if (!hintConfig.condition(contract)) return null; - - return ( - <div className="flex items-center gap-3 p-3 bg-[rgba(117,170,252,0.05)] border border-[rgba(117,170,252,0.2)]"> - <span className="font-mono text-xs text-[#9bc3ff]"> - {hintConfig.message(contract)} - </span> - <button - onClick={() => onAdvancePhase(hintConfig.nextPhase)} - className="px-3 py-1 font-mono text-xs text-[#dbe7ff] bg-[#0f3c78] border border-[#3f6fb3] hover:bg-[#153667] transition-colors uppercase whitespace-nowrap" - > - Advance to {hintConfig.nextPhase} - </button> - </div> - ); -} - -export function getNextPhase(currentPhase: ContractPhase): ContractPhase | null { - const currentIndex = phaseOrder.indexOf(currentPhase); - if (currentIndex === -1 || currentIndex === phaseOrder.length - 1) { - return null; - } - return phaseOrder[currentIndex + 1]; -} - -export function getPreviousPhase(currentPhase: ContractPhase): ContractPhase | null { - const currentIndex = phaseOrder.indexOf(currentPhase); - if (currentIndex <= 0) { - return null; - } - return phaseOrder[currentIndex - 1]; -} |
