Add Task Contract Type for one-off adhoc tasks (#2)

1 files changed, 71 insertions, 61 deletions

diff --git a/makima/src/server/handlers/contracts.rs b/makima/src/server/handlers/contracts.rs
index 09f78e6..afca3d7 100644
--- a/makima/src/server/handlers/contracts.rs
+++ b/makima/src/server/handlers/contracts.rs
@@ -259,75 +259,85 @@ pub async fn create_contract(
 
     match repository::create_contract_for_owner(pool, auth.owner_id, req.clone()).await {
         Ok(contract) => {
-            // Create supervisor task for this contract
-            let supervisor_name = format!("{} Supervisor", contract.name);
-            let supervisor_plan = format!(
-                "You are the supervisor for contract '{}'. Your goal is to drive this contract to completion.\n\n{}",
-                contract.name,
-                contract.description.as_deref().unwrap_or("No description provided.")
-            );
-
-            // Get repository info from contract if available
-            let repo_url = {
-                // Try to get the first repository associated with this contract
-                match repository::list_contract_repositories(pool, contract.id).await {
-                    Ok(repos) if !repos.is_empty() => {
-                        let repo = &repos[0];
-                        repo.repository_url.clone()
+            // Only create supervisor task for non-task type contracts
+            // Task type contracts are lightweight adhoc tasks that don't need supervisors
+            if contract.contract_type != crate::db::models::CONTRACT_TYPE_TASK {
+                // Create supervisor task for this contract
+                let supervisor_name = format!("{} Supervisor", contract.name);
+                let supervisor_plan = format!(
+                    "You are the supervisor for contract '{}'. Your goal is to drive this contract to completion.\n\n{}",
+                    contract.name,
+                    contract.description.as_deref().unwrap_or("No description provided.")
+                );
+
+                // Get repository info from contract if available
+                let repo_url = {
+                    // Try to get the first repository associated with this contract
+                    match repository::list_contract_repositories(pool, contract.id).await {
+                        Ok(repos) if !repos.is_empty() => {
+                            let repo = &repos[0];
+                            repo.repository_url.clone()
+                        }
+                        _ => None,
                     }
-                    _ => None,
-                }
-            };
-
-            let supervisor_req = crate::db::models::CreateTaskRequest {
-                name: supervisor_name,
-                description: None,
-                plan: supervisor_plan,
-                repository_url: repo_url,
-                base_branch: None,
-                target_branch: None,
-                parent_task_id: None,
-                contract_id: contract.id,
-                target_repo_path: None,
-                completion_action: None,
-                continue_from_task_id: None,
-                copy_files: None,
-                is_supervisor: true,
-                checkpoint_sha: None,
-                priority: 0,
-                merge_mode: None,
-            };
-
-            match repository::create_task_for_owner(pool, auth.owner_id, supervisor_req).await {
-                Ok(supervisor_task) => {
-                    tracing::info!(
-                        contract_id = %contract.id,
-                        supervisor_task_id = %supervisor_task.id,
-                        is_supervisor = supervisor_task.is_supervisor,
-                        "Created supervisor task for contract"
-                    );
+                };
+
+                let supervisor_req = crate::db::models::CreateTaskRequest {
+                    name: supervisor_name,
+                    description: None,
+                    plan: supervisor_plan,
+                    repository_url: repo_url,
+                    base_branch: None,
+                    target_branch: None,
+                    parent_task_id: None,
+                    contract_id: contract.id,
+                    target_repo_path: None,
+                    completion_action: None,
+                    continue_from_task_id: None,
+                    copy_files: None,
+                    is_supervisor: true,
+                    checkpoint_sha: None,
+                    priority: 0,
+                    merge_mode: None,
+                };
+
+                match repository::create_task_for_owner(pool, auth.owner_id, supervisor_req).await {
+                    Ok(supervisor_task) => {
+                        tracing::info!(
+                            contract_id = %contract.id,
+                            supervisor_task_id = %supervisor_task.id,
+                            is_supervisor = supervisor_task.is_supervisor,
+                            "Created supervisor task for contract"
+                        );
 
-                    // Update contract with supervisor_task_id
-                    let update_req = crate::db::models::UpdateContractRequest {
-                        supervisor_task_id: Some(supervisor_task.id),
-                        version: Some(contract.version),
-                        ..Default::default()
-                    };
-                    if let Err(e) = repository::update_contract_for_owner(pool, contract.id, auth.owner_id, update_req).await {
+                        // Update contract with supervisor_task_id
+                        let update_req = crate::db::models::UpdateContractRequest {
+                            supervisor_task_id: Some(supervisor_task.id),
+                            version: Some(contract.version),
+                            ..Default::default()
+                        };
+                        if let Err(e) = repository::update_contract_for_owner(pool, contract.id, auth.owner_id, update_req).await {
+                            tracing::warn!(
+                                contract_id = %contract.id,
+                                error = %e,
+                                "Failed to link supervisor task to contract"
+                            );
+                        }
+                    }
+                    Err(e) => {
                         tracing::warn!(
                             contract_id = %contract.id,
                             error = %e,
-                            "Failed to link supervisor task to contract"
+                            "Failed to create supervisor task for contract"
                         );
                     }
                 }
-                Err(e) => {
-                    tracing::warn!(
-                        contract_id = %contract.id,
-                        error = %e,
-                        "Failed to create supervisor task for contract"
-                    );
-                }
+            } else {
+                tracing::info!(
+                    contract_id = %contract.id,
+                    contract_type = %contract.contract_type,
+                    "Skipping supervisor creation for task-type contract"
+                );
             }
 
             // Get the summary version with counts