summaryrefslogtreecommitdiff
path: root/makima/frontend/src/components/contracts/TaskDerivationPreview.tsx
diff options
context:
space:
mode:
authorsoryu <soryu@soryu.co>2026-05-01 23:56:51 +0100
committerGitHub <noreply@github.com>2026-05-01 23:56:51 +0100
commite11759447b1ac00becfb1e979e488f7f9c9cf478 (patch)
treef8a58368de3f6dda3f2f5c1af34e869a0e714205 /makima/frontend/src/components/contracts/TaskDerivationPreview.tsx
parent80085c7cfa9d679ed3e3fd54a7d55fa8ab1addef (diff)
downloadsoryu-e11759447b1ac00becfb1e979e488f7f9c9cf478.tar.gz
soryu-e11759447b1ac00becfb1e979e488f7f9c9cf478.zip
chore(cleanup): Phase 5 contracts removal + tmp directive + 30-day expiry + scroll fix (#118)
Sweeping cleanup across the surface and the wire. Net: -14k LOC of legacy contracts code, plus the tmp/scroll/UX fixes the user asked for. ## Sidebar/editor independent scroll Replace `height: calc(100vh - 80px)` (which assumed an 80px masthead and quietly clipped or pushed the whole page below the fold when the masthead was taller) with `h-screen + overflow-hidden` on the page root and proper `flex-1 min-h-0` sizing on `<main>`. Sidebar and editor pane now manage their own scroll independently; the page itself never scrolls. Same fix in /tmp/:taskId. ## tmp directive — real backing for orphans/ephemerals New migration `20260501100000_tmp_directive_and_clear_orphans.sql`: * Adds `directives.is_tmp` BOOLEAN NOT NULL DEFAULT false. * Partial unique index `(owner_id) WHERE is_tmp` — at most ONE tmp directive per owner. * Hard-deletes every existing orphan task (`directive_id IS NULL`). Per the user spec: "ALSO there are TOO MANY old tasks in tmp, we need to remove all of them as well." New repository helpers: * `get_or_create_tmp_directive(pool, owner_id) -> Directive` INSERT ON CONFLICT DO NOTHING + fallback SELECT, race-safe. * `list_all_tmp_directives` — drives the expiry sweep. * `delete_expired_tmp_tasks(tmp_directive_id) -> u64`. * `list_tmp_tasks_for_owner` (replaces `list_orphan_tasks_for_owner`). `mesh::create_task`: every top-level task must have a directive. If a caller doesn't supply `directive_id` and isn't a subtask, attach to the caller's tmp directive (auto-creating it on first use). `list_directives_for_owner` filters out `is_tmp=true` so the scratchpad directive doesn't pollute the contract list — surfaced via the sidebar's `tmp/` folder instead. ## 30-day expiry on tmp tasks New `phase_tmp_expiry` in the directive reconciler. Throttled to once per hour: enumerates every tmp directive, calls `delete_expired_tmp_tasks`, logs the count. The actual delete is `WHERE created_at < NOW() - INTERVAL '30 days'` and is fast on the existing index. Subtasks die via FK cascade. ## Phase 5 — contracts removed ### Frontend Deleted entire `/contracts` surface: * routes: `contracts.tsx`, `contract-file.tsx` * components/contracts: ContractList, ContractDetail, ContractCliInput, ContractContextMenu, CommandModePanel, PhaseBadge, PhaseHint, PhaseDeliverablesPanel, PhaseProgressBar, QuickActionButtons, RepositoryPanel, TaskDerivationPreview * (Kept `PhaseConfirmationModal` — used outside the contracts surface by `TaskOutput` and `PhaseConfirmationNotification`.) * Routes deregistered from `main.tsx`; nav entry removed from `NavStrip`. ### Backend handlers Deleted: `contracts.rs` (2.4k LOC), `contract_chat.rs` (3.2k LOC), `contract_daemon.rs` (~940 LOC), `contract_discuss.rs` (~590 LOC), `transcript_analysis.rs` (~690 LOC). All `/api/v1/contracts/*` routes deregistered. OpenAPI entries dropped. Module declarations removed from `server/handlers/mod.rs`. ### CLI Removed `makima contract` and `makima supervisor` subcommands. Deleted `daemon/cli/contract.rs` and `daemon/cli/supervisor.rs`. Bin dispatch trimmed (~377 LOC). ### Orchestrator Removed the contract-spawn path from `phase_execution` (`spawn_step_contract` and its caller). `directive_steps.contract_type` now logs a warning and falls through to standalone-task spawn. Column itself stays — old data still reads, just no longer triggers a contract+supervisor spawn. ### TUI `Action::PerformCreateContract` is now a no-op that surfaces a status message: "Contracts have been removed. Use directives instead." The TUI form is dead code pending a wider refresh. ## Out of scope (deliberately left) * Contracts DB tables (`contracts`, `contract_repositories`, `contract_chat_history`, `contract_events`, `contract_templates`) are retained for historical data + because some peripheral code still joins to them in TaskSummary queries. * `mesh_supervisor` handlers are retained — they aren't only used by contracts (some mesh-level supervisor behaviour persists), and the cross-cutting cleanup is bigger than this PR. * `directive_steps.contract_type` column itself isn't dropped; just no longer functional. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'makima/frontend/src/components/contracts/TaskDerivationPreview.tsx')
-rw-r--r--makima/frontend/src/components/contracts/TaskDerivationPreview.tsx221
1 files changed, 0 insertions, 221 deletions
diff --git a/makima/frontend/src/components/contracts/TaskDerivationPreview.tsx b/makima/frontend/src/components/contracts/TaskDerivationPreview.tsx
deleted file mode 100644
index 07421ef..0000000
--- a/makima/frontend/src/components/contracts/TaskDerivationPreview.tsx
+++ /dev/null
@@ -1,221 +0,0 @@
-import { useState, useCallback } from "react";
-
-export interface ParsedTask {
- name: string;
- description?: string;
- group?: string;
- order: number;
- completed: boolean;
- dependencies: string[];
-}
-
-interface TaskDerivationPreviewProps {
- tasks: ParsedTask[];
- groups: string[];
- fileName: string;
- onCreateTasks: (selectedTasks: ParsedTask[]) => void;
- onCancel: () => void;
- loading?: boolean;
-}
-
-export function TaskDerivationPreview({
- tasks,
- groups,
- fileName,
- onCreateTasks,
- onCancel,
- loading = false,
-}: TaskDerivationPreviewProps) {
- const [selectedIndices, setSelectedIndices] = useState<Set<number>>(
- new Set(tasks.map((_, i) => i)) // Select all by default
- );
-
- const toggleTask = useCallback((index: number) => {
- setSelectedIndices((prev) => {
- const newSet = new Set(prev);
- if (newSet.has(index)) {
- newSet.delete(index);
- } else {
- newSet.add(index);
- }
- return newSet;
- });
- }, []);
-
- const selectAll = useCallback(() => {
- setSelectedIndices(new Set(tasks.map((_, i) => i)));
- }, [tasks]);
-
- const selectNone = useCallback(() => {
- setSelectedIndices(new Set());
- }, []);
-
- const handleCreate = useCallback(() => {
- const selectedTasks = tasks.filter((_, i) => selectedIndices.has(i));
- onCreateTasks(selectedTasks);
- }, [tasks, selectedIndices, onCreateTasks]);
-
- // Group tasks by their group property
- const tasksByGroup = tasks.reduce((acc, task, index) => {
- const groupKey = task.group || "Ungrouped";
- if (!acc[groupKey]) {
- acc[groupKey] = [];
- }
- acc[groupKey].push({ task, index });
- return acc;
- }, {} as Record<string, { task: ParsedTask; index: number }[]>);
-
- const selectedCount = selectedIndices.size;
- const totalCount = tasks.length;
-
- return (
- <div className="fixed inset-0 z-50 flex items-center justify-center bg-black/50">
- <div className="w-full max-w-2xl p-6 bg-[#0a1628] border border-[rgba(117,170,252,0.3)] max-h-[80vh] flex flex-col">
- {/* Header */}
- <div className="flex items-center justify-between mb-4">
- <div>
- <h3 className="font-mono text-sm text-[#75aafc] uppercase">
- Create Tasks from Document
- </h3>
- <p className="font-mono text-xs text-[#555] mt-1">
- Source: {fileName}
- </p>
- </div>
- <div className="flex items-center gap-2">
- <button
- onClick={selectAll}
- className="font-mono text-[10px] text-[#75aafc] hover:text-[#9bc3ff] transition-colors"
- >
- Select All
- </button>
- <span className="text-[#555]">|</span>
- <button
- onClick={selectNone}
- className="font-mono text-[10px] text-[#75aafc] hover:text-[#9bc3ff] transition-colors"
- >
- Select None
- </button>
- </div>
- </div>
-
- {/* Task List */}
- <div className="flex-1 overflow-y-auto space-y-4 mb-4">
- {groups.length > 0 ? (
- // Grouped view
- Object.entries(tasksByGroup).map(([groupName, groupTasks]) => (
- <div key={groupName} className="space-y-2">
- <h4 className="font-mono text-xs text-[#9bc3ff] uppercase border-b border-[rgba(117,170,252,0.2)] pb-1">
- {groupName}
- </h4>
- {groupTasks.map(({ task, index }) => (
- <TaskItem
- key={index}
- task={task}
- index={index}
- selected={selectedIndices.has(index)}
- onToggle={() => toggleTask(index)}
- />
- ))}
- </div>
- ))
- ) : (
- // Flat view
- tasks.map((task, index) => (
- <TaskItem
- key={index}
- task={task}
- index={index}
- selected={selectedIndices.has(index)}
- onToggle={() => toggleTask(index)}
- />
- ))
- )}
- </div>
-
- {/* Footer */}
- <div className="flex items-center justify-between pt-4 border-t border-[rgba(117,170,252,0.2)]">
- <span className="font-mono text-xs text-[#555]">
- {selectedCount} of {totalCount} tasks selected
- </span>
- <div className="flex gap-2">
- <button
- onClick={onCancel}
- disabled={loading}
- className="px-4 py-2 font-mono text-xs text-[#9bc3ff] hover:text-[#dbe7ff] transition-colors disabled:opacity-50"
- >
- Cancel
- </button>
- <button
- onClick={handleCreate}
- disabled={loading || selectedCount === 0}
- className="px-4 py-2 font-mono text-xs text-[#dbe7ff] bg-[#0f3c78] border border-[#3f6fb3] hover:bg-[#153667] transition-colors disabled:opacity-50 disabled:cursor-not-allowed"
- >
- {loading ? "Creating..." : `Create ${selectedCount} Task${selectedCount !== 1 ? "s" : ""}`}
- </button>
- </div>
- </div>
-
- {/* Chaining info */}
- {selectedCount > 1 && (
- <p className="font-mono text-[10px] text-[#555] mt-2 text-center">
- Tasks will be chained: each task continues from the previous one's work
- </p>
- )}
- </div>
- </div>
- );
-}
-
-function TaskItem({
- task,
- index,
- selected,
- onToggle,
-}: {
- task: ParsedTask;
- index: number;
- selected: boolean;
- onToggle: () => void;
-}) {
- return (
- <button
- onClick={onToggle}
- className={`w-full text-left p-3 border transition-colors ${
- selected
- ? "border-[#75aafc] bg-[rgba(117,170,252,0.1)]"
- : "border-[rgba(117,170,252,0.15)] hover:border-[rgba(117,170,252,0.3)]"
- }`}
- >
- <div className="flex items-start gap-2">
- <span
- className={`font-mono text-xs mt-0.5 ${
- selected ? "text-[#75aafc]" : "text-[#555]"
- }`}
- >
- {selected ? "[x]" : "[ ]"}
- </span>
- <div className="flex-1 min-w-0">
- <div className="flex items-center gap-2">
- <span className="font-mono text-[10px] text-[#555]">#{index + 1}</span>
- <span className="font-mono text-sm text-[#dbe7ff]">{task.name}</span>
- {task.completed && (
- <span className="font-mono text-[9px] text-green-400 uppercase">
- done in source
- </span>
- )}
- </div>
- {task.description && (
- <p className="font-mono text-xs text-[#555] mt-1 truncate">
- {task.description}
- </p>
- )}
- {task.dependencies.length > 0 && (
- <p className="font-mono text-[10px] text-[#75aafc] mt-1">
- Depends on: {task.dependencies.join(", ")}
- </p>
- )}
- </div>
- </div>
- </button>
- );
-}