summaryrefslogtreecommitdiff
path: root/makima/frontend/src/components/contracts/PhaseProgressBar.tsx
diff options
context:
space:
mode:
authorsoryu <soryu@soryu.co>2026-05-01 23:56:51 +0100
committerGitHub <noreply@github.com>2026-05-01 23:56:51 +0100
commite11759447b1ac00becfb1e979e488f7f9c9cf478 (patch)
treef8a58368de3f6dda3f2f5c1af34e869a0e714205 /makima/frontend/src/components/contracts/PhaseProgressBar.tsx
parent80085c7cfa9d679ed3e3fd54a7d55fa8ab1addef (diff)
downloadsoryu-e11759447b1ac00becfb1e979e488f7f9c9cf478.tar.gz
soryu-e11759447b1ac00becfb1e979e488f7f9c9cf478.zip
chore(cleanup): Phase 5 contracts removal + tmp directive + 30-day expiry + scroll fix (#118)
Sweeping cleanup across the surface and the wire. Net: -14k LOC of legacy contracts code, plus the tmp/scroll/UX fixes the user asked for. ## Sidebar/editor independent scroll Replace `height: calc(100vh - 80px)` (which assumed an 80px masthead and quietly clipped or pushed the whole page below the fold when the masthead was taller) with `h-screen + overflow-hidden` on the page root and proper `flex-1 min-h-0` sizing on `<main>`. Sidebar and editor pane now manage their own scroll independently; the page itself never scrolls. Same fix in /tmp/:taskId. ## tmp directive — real backing for orphans/ephemerals New migration `20260501100000_tmp_directive_and_clear_orphans.sql`: * Adds `directives.is_tmp` BOOLEAN NOT NULL DEFAULT false. * Partial unique index `(owner_id) WHERE is_tmp` — at most ONE tmp directive per owner. * Hard-deletes every existing orphan task (`directive_id IS NULL`). Per the user spec: "ALSO there are TOO MANY old tasks in tmp, we need to remove all of them as well." New repository helpers: * `get_or_create_tmp_directive(pool, owner_id) -> Directive` INSERT ON CONFLICT DO NOTHING + fallback SELECT, race-safe. * `list_all_tmp_directives` — drives the expiry sweep. * `delete_expired_tmp_tasks(tmp_directive_id) -> u64`. * `list_tmp_tasks_for_owner` (replaces `list_orphan_tasks_for_owner`). `mesh::create_task`: every top-level task must have a directive. If a caller doesn't supply `directive_id` and isn't a subtask, attach to the caller's tmp directive (auto-creating it on first use). `list_directives_for_owner` filters out `is_tmp=true` so the scratchpad directive doesn't pollute the contract list — surfaced via the sidebar's `tmp/` folder instead. ## 30-day expiry on tmp tasks New `phase_tmp_expiry` in the directive reconciler. Throttled to once per hour: enumerates every tmp directive, calls `delete_expired_tmp_tasks`, logs the count. The actual delete is `WHERE created_at < NOW() - INTERVAL '30 days'` and is fast on the existing index. Subtasks die via FK cascade. ## Phase 5 — contracts removed ### Frontend Deleted entire `/contracts` surface: * routes: `contracts.tsx`, `contract-file.tsx` * components/contracts: ContractList, ContractDetail, ContractCliInput, ContractContextMenu, CommandModePanel, PhaseBadge, PhaseHint, PhaseDeliverablesPanel, PhaseProgressBar, QuickActionButtons, RepositoryPanel, TaskDerivationPreview * (Kept `PhaseConfirmationModal` — used outside the contracts surface by `TaskOutput` and `PhaseConfirmationNotification`.) * Routes deregistered from `main.tsx`; nav entry removed from `NavStrip`. ### Backend handlers Deleted: `contracts.rs` (2.4k LOC), `contract_chat.rs` (3.2k LOC), `contract_daemon.rs` (~940 LOC), `contract_discuss.rs` (~590 LOC), `transcript_analysis.rs` (~690 LOC). All `/api/v1/contracts/*` routes deregistered. OpenAPI entries dropped. Module declarations removed from `server/handlers/mod.rs`. ### CLI Removed `makima contract` and `makima supervisor` subcommands. Deleted `daemon/cli/contract.rs` and `daemon/cli/supervisor.rs`. Bin dispatch trimmed (~377 LOC). ### Orchestrator Removed the contract-spawn path from `phase_execution` (`spawn_step_contract` and its caller). `directive_steps.contract_type` now logs a warning and falls through to standalone-task spawn. Column itself stays — old data still reads, just no longer triggers a contract+supervisor spawn. ### TUI `Action::PerformCreateContract` is now a no-op that surfaces a status message: "Contracts have been removed. Use directives instead." The TUI form is dead code pending a wider refresh. ## Out of scope (deliberately left) * Contracts DB tables (`contracts`, `contract_repositories`, `contract_chat_history`, `contract_events`, `contract_templates`) are retained for historical data + because some peripheral code still joins to them in TaskSummary queries. * `mesh_supervisor` handlers are retained — they aren't only used by contracts (some mesh-level supervisor behaviour persists), and the cross-cutting cleanup is bigger than this PR. * `directive_steps.contract_type` column itself isn't dropped; just no longer functional. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'makima/frontend/src/components/contracts/PhaseProgressBar.tsx')
-rw-r--r--makima/frontend/src/components/contracts/PhaseProgressBar.tsx149
1 files changed, 0 insertions, 149 deletions
diff --git a/makima/frontend/src/components/contracts/PhaseProgressBar.tsx b/makima/frontend/src/components/contracts/PhaseProgressBar.tsx
deleted file mode 100644
index 9589db9..0000000
--- a/makima/frontend/src/components/contracts/PhaseProgressBar.tsx
+++ /dev/null
@@ -1,149 +0,0 @@
-import type { ContractPhase, ContractType } from "../../lib/api";
-import { getValidPhases } from "../../lib/api";
-
-interface PhaseProgressBarProps {
- currentPhase: ContractPhase;
- contractType?: ContractType;
- onPhaseClick?: (phase: ContractPhase) => void;
- readonly?: boolean;
-}
-
-const phases: ContractPhase[] = ["research", "specify", "plan", "execute", "review"];
-
-const phaseLabels: Record<ContractPhase, string> = {
- research: "Research",
- specify: "Specify",
- plan: "Plan",
- execute: "Execute",
- review: "Review",
-};
-
-const phaseColors: Record<ContractPhase, { active: string; inactive: string; completed: string }> = {
- research: {
- active: "bg-purple-400 border-purple-400",
- inactive: "bg-transparent border-purple-400/30",
- completed: "bg-purple-400/50 border-purple-400/50",
- },
- specify: {
- active: "bg-blue-400 border-blue-400",
- inactive: "bg-transparent border-blue-400/30",
- completed: "bg-blue-400/50 border-blue-400/50",
- },
- plan: {
- active: "bg-cyan-400 border-cyan-400",
- inactive: "bg-transparent border-cyan-400/30",
- completed: "bg-cyan-400/50 border-cyan-400/50",
- },
- execute: {
- active: "bg-yellow-400 border-yellow-400",
- inactive: "bg-transparent border-yellow-400/30",
- completed: "bg-yellow-400/50 border-yellow-400/50",
- },
- review: {
- active: "bg-green-400 border-green-400",
- inactive: "bg-transparent border-green-400/30",
- completed: "bg-green-400/50 border-green-400/50",
- },
-};
-
-export function PhaseProgressBar({
- currentPhase,
- contractType,
- onPhaseClick,
- readonly = false,
-}: PhaseProgressBarProps) {
- const visiblePhases = contractType ? getValidPhases(contractType) : phases;
- const currentIndex = visiblePhases.indexOf(currentPhase);
-
- return (
- <div className="flex items-center gap-1">
- {visiblePhases.map((phase, index) => {
- const isActive = phase === currentPhase;
- const isCompleted = index < currentIndex;
- const colors = phaseColors[phase];
- const colorClass = isActive
- ? colors.active
- : isCompleted
- ? colors.completed
- : colors.inactive;
-
- const canClick = !readonly && onPhaseClick;
-
- return (
- <div key={phase} className="flex items-center">
- {/* Phase node */}
- <button
- onClick={() => canClick && onPhaseClick(phase)}
- disabled={readonly}
- className={`
- relative group flex flex-col items-center
- ${canClick ? "cursor-pointer" : "cursor-default"}
- `}
- >
- {/* Circle */}
- <div
- className={`
- w-3 h-3 rounded-full border-2 transition-all
- ${colorClass}
- ${canClick && !isActive ? "hover:scale-110" : ""}
- `}
- />
- {/* Label */}
- <span
- className={`
- absolute top-4 font-mono text-[9px] uppercase tracking-wide whitespace-nowrap
- ${isActive ? "text-[#dbe7ff]" : "text-[#555]"}
- ${canClick && !isActive ? "group-hover:text-[#75aafc]" : ""}
- `}
- >
- {phaseLabels[phase]}
- </span>
- </button>
-
- {/* Connector line */}
- {index < visiblePhases.length - 1 && (
- <div
- className={`
- w-8 h-0.5 mx-1
- ${index < currentIndex ? "bg-[#3f6fb3]" : "bg-[rgba(117,170,252,0.15)]"}
- `}
- />
- )}
- </div>
- );
- })}
- </div>
- );
-}
-
-export function PhaseProgressBarCompact({
- currentPhase,
- contractType,
-}: {
- currentPhase: ContractPhase;
- contractType?: ContractType;
-}) {
- const visiblePhases = contractType ? getValidPhases(contractType) : phases;
- const currentIndex = visiblePhases.indexOf(currentPhase);
-
- return (
- <div className="flex items-center gap-0.5">
- {visiblePhases.map((phase, index) => {
- const isActive = phase === currentPhase;
- const isCompleted = index < currentIndex;
- const colors = phaseColors[phase];
-
- return (
- <div
- key={phase}
- className={`
- w-2 h-2 rounded-full border
- ${isActive ? colors.active : isCompleted ? colors.completed : colors.inactive}
- `}
- title={phaseLabels[phase]}
- />
- );
- })}
- </div>
- );
-}