diff options
| author | soryu <soryu@soryu.co> | 2026-02-17 02:04:46 +0000 |
|---|---|---|
| committer | soryu <soryu@soryu.co> | 2026-02-17 02:04:46 +0000 |
| commit | 2f2dc4509799a2d932e4a0e39b9e8caeed5163fe (patch) | |
| tree | 40386f7b4708901fed9e6996836a726e16dabdf7 | |
| parent | 178d7a2220f5356996726d993a1dbe48cdd3616a (diff) | |
| parent | 0f403e44aa0be23acbcccb767870dbaf13474166 (diff) | |
| download | soryu-2f2dc4509799a2d932e4a0e39b9e8caeed5163fe.tar.gz soryu-2f2dc4509799a2d932e4a0e39b9e8caeed5163fe.zip | |
Merge remote-tracking branch 'origin/makima/soryu-co-soryu--generate-pr-titles-from-step-conte-1c4fa4b0' into makima/directive-soryu-co-soryu-f2076752
# Conflicts:
# makima/src/orchestration/directive.rs
| -rw-r--r-- | makima/src/orchestration/directive.rs | 30 |
1 files changed, 22 insertions, 8 deletions
diff --git a/makima/src/orchestration/directive.rs b/makima/src/orchestration/directive.rs index 581f869..eb157a3 100644 --- a/makima/src/orchestration/directive.rs +++ b/makima/src/orchestration/directive.rs @@ -1378,9 +1378,14 @@ git checkout -b "$NEW_BRANCH" origin/{base_branch} git push -u origin "$NEW_BRANCH" ``` -3. Create a new PR. Generate a concise, descriptive PR title (max 72 characters) based on the steps completed. -The title should summarize what the changes actually accomplish — do NOT just use the directive name "{title}". -Focus on the actual work done in the steps listed below. +3. Generate a descriptive PR title and create a new PR: + +Based on the steps completed above, generate a descriptive PR title that summarizes the actual changes (not just the directive name "{title}"). The title should: +- Be concise (under 72 characters) +- Describe WHAT was done, not just the project name +- Use conventional commit style if appropriate (feat:, fix:, refactor:, etc.) + +Then create the PR: ``` gh pr create --title "<YOUR_GENERATED_TITLE>" --body "{pr_body}" --head "$NEW_BRANCH" --base {base_branch} ``` @@ -1446,10 +1451,13 @@ git checkout -b {directive_branch} origin/{base_branch} git push -u origin {directive_branch} ``` -Then create the PR. You MUST generate a concise, descriptive PR title (max 72 characters) based on the steps completed above. -The title should summarize what the changes actually accomplish — do NOT just use the directive name "{title}". +Then generate a descriptive PR title and create the PR: + +Based on the steps completed above, generate a descriptive PR title that summarizes the actual changes (not just the directive name "{title}"). The title should: +- Be concise (under 72 characters) +- Describe WHAT was done, not just the project name +- Use conventional commit style if appropriate (feat:, fix:, refactor:, etc.) For example, instead of "soryu-co/soryu - makima" use something like "Fix order lifecycle, PR update, and contracts overflow". -Focus on the actual work done in the steps. ``` gh pr create --title "<YOUR_GENERATED_TITLE>" --body "{pr_body}" --head {directive_branch} --base {base_branch} @@ -1514,9 +1522,15 @@ Done — the PR already exists. git ls-remote --heads origin {pr_branch} ``` -4. If the branch exists, create the PR: +4. If the branch exists, generate a descriptive PR title and create the PR: + +Based on the branch name and directive "{title}", generate a descriptive PR title that summarizes the actual changes. The title should: +- Be concise (under 72 characters) +- Describe WHAT was done, not just the project name +- Use conventional commit style if appropriate (feat:, fix:, refactor:, etc.) + ``` -gh pr create --title "{title}" --body "Directive PR verification — auto-created" --head {pr_branch} --base {base_branch} +gh pr create --title "<YOUR_GENERATED_TITLE>" --body "Directive PR verification — auto-created" --head {pr_branch} --base {base_branch} ``` Then store the resulting URL: ``` |
