summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsoryu <soryu@soryu.co>2026-02-17 00:18:11 +0000
committersoryu <soryu@soryu.co>2026-02-17 00:18:11 +0000
commit01cb137bccf41ee0fbe920d9d69ca8755dba61eb (patch)
treed5429658a90c4be9a2984617118d2c843cadfdf6
parent32d769db051ebb1a410fc56fab3b1c38a7ffa658 (diff)
parent5b1ef2cce7836ee5f70554c301f383f54f5591ad (diff)
downloadsoryu-makima/directive-soryu-co-soryu---makima-ad8bee48-v1771285017.tar.gz
soryu-makima/directive-soryu-co-soryu---makima-ad8bee48-v1771285017.zip
Merge remote-tracking branch 'origin/makima/soryu-co-soryu---makima--name-directive-prs-based--262a2a0b' into temp-pr-updatemakima/directive-soryu-co-soryu---makima-ad8bee48-v1771285017
-rw-r--r--makima/src/orchestration/directive.rs22
1 files changed, 18 insertions, 4 deletions
diff --git a/makima/src/orchestration/directive.rs b/makima/src/orchestration/directive.rs
index 6306404..5c134d6 100644
--- a/makima/src/orchestration/directive.rs
+++ b/makima/src/orchestration/directive.rs
@@ -1359,6 +1359,11 @@ gh pr view {pr_url} --json state --jq '.state'
The previous PR was already merged/closed. You need to create a NEW PR with a fresh branch.
+Goal: {goal}
+
+Steps completed:
+{step_summary}
+
1. Clear the old PR URL:
```
makima directive update --pr-url ""
@@ -1373,10 +1378,13 @@ git checkout -b "$NEW_BRANCH" origin/{base_branch}
git push -u origin "$NEW_BRANCH"
```
-3. Create a new PR:
+3. Create a new PR. Generate a concise, descriptive PR title (max 72 characters) based on the steps completed.
+The title should summarize what the changes actually accomplish — do NOT just use the directive name "{title}".
+Focus on the actual work done in the steps listed below.
```
-gh pr create --title "{title}" --body "{pr_body}" --head "$NEW_BRANCH" --base {base_branch}
+gh pr create --title "<YOUR_GENERATED_TITLE>" --body "{pr_body}" --head "$NEW_BRANCH" --base {base_branch}
```
+Replace <YOUR_GENERATED_TITLE> with the concise descriptive title you generated.
4. Store the new PR URL:
```
@@ -1408,6 +1416,7 @@ git push origin {directive_branch}
Already-merged branches will be a no-op. If there are merge conflicts, resolve them sensibly.
"#,
title = directive.title,
+ goal = directive.goal,
pr_url = pr_url,
directive_branch = directive_branch,
base_branch = base_branch,
@@ -1437,10 +1446,15 @@ git checkout -b {directive_branch} origin/{base_branch}
git push -u origin {directive_branch}
```
-Then create the PR:
+Then create the PR. You MUST generate a concise, descriptive PR title (max 72 characters) based on the steps completed above.
+The title should summarize what the changes actually accomplish — do NOT just use the directive name "{title}".
+For example, instead of "soryu-co/soryu - makima" use something like "Fix order lifecycle, PR update, and contracts overflow".
+Focus on the actual work done in the steps.
+
```
-gh pr create --title "{title}" --body "{pr_body}" --head {directive_branch} --base {base_branch}
+gh pr create --title "<YOUR_GENERATED_TITLE>" --body "{pr_body}" --head {directive_branch} --base {base_branch}
```
+Replace <YOUR_GENERATED_TITLE> with the concise descriptive title you generated.
IMPORTANT: After creating the PR, you MUST store the PR URL so the directive system can track it.